This repository was archived by the owner on Jul 2, 2023. It is now read-only.
Add a Cargo.lock file #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Jakob-Naucke Can you please rebase this PR and we can merge it :) |
to avoid accumulating incompatible versions. Signed-off-by: Jakob Naucke <[email protected]>
Member
Author
|
Thanks @jialez0 -- this Cargo.lock is from just now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid accumulating incompatible versions.
Signed-off-by: Jakob Naucke [email protected]
The one provided here was built with
--no-default-features. https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries suggests binary applications should lock their versions. If you disagree, we can also use more rigorous version locks inCargo.toml. What I'd like to avoid is random breakage, which happened on s390x with socket2 v0.4.3 in combination with libc v0.2.113 (see rust-lang/libc#2645 (comment)).