Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python314.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/18236997477 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19284509137. Examine the logs at this URL for more detail.

@xhochy
Copy link
Member

xhochy commented Oct 4, 2025

@setu4993 What's the reason you need to change the requirements? Are they already wrong in the non-migrated version?

@setu4993
Copy link
Member

setu4993 commented Oct 4, 2025

@setu4993 What's the reason you need to change the requirements? Are they already wrong in the non-migrated version?

Yeah, the datasets dependency was pinned to a very old version, which was causing some of the CI failures. I think I can revert the other changes.

Looking through what's happening, I believe we'll need multiprocess v0.70.17 to be published for Python 3.14, because that is pinned on datasets: https://github.com/huggingface/datasets/blob/main/setup.py#L127

Comment on lines -72 to -74
# temp: fix until https://github.com/conda-forge/multiprocess-feedstock/pull/46
# percolates far enough so that the solver doesn't pull in an old version anymore
- dill >=0.3.6
Copy link
Member

@setu4993 setu4993 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore because that is from a few months years ago.

@setu4993
Copy link
Member

setu4993 commented Oct 4, 2025

Blocked on: conda-forge/multiprocess-feedstock#57

run:
- python
- huggingface_hub >=0.16.4,<1.0
- huggingface_hub >=0.16.4,<2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been fixed earlier.

@h-vetinari
Copy link
Member

I believe we'll need multiprocess v0.70.17 to be published for Python 3.14, because that is pinned on datasets: https://github.com/huggingface/datasets/blob/main/setup.py#L127

I think we should patch out a too-tight pin from datasets rather than mess around with migrating for old multiprocess versions

@setu4993
Copy link
Member

setu4993 commented Oct 4, 2025

I believe we'll need multiprocess v0.70.17 to be published for Python 3.14, because that is pinned on datasets: https://github.com/huggingface/datasets/blob/main/setup.py#L127

I think we should patch out a too-tight pin from datasets rather than mess around with migrating for old multiprocess versions

I don't quite understand how that'd work, but that sounds like a better option, yes.

This is also only for tests, and not a build / run dependency, so I'm also wondering if we can just skip those tests for Python 3.14.

@setu4993
Copy link
Member

Dependencies are good now, but the tests are failing because of huggingface/datasets#7813, which is downstream of uqfoundation/dill#725.

@setu4993
Copy link
Member

WIP fixes in: huggingface/datasets#7817, uqfoundation/dill#724.

@Ahajha
Copy link

Ahajha commented Oct 26, 2025

Question for anyone, why do these rebuilds even need to happen? Tokenizers build for the 3.9 stable ABI, so theoretically one build should work for any python version? Do we have to have separate packages?

@setu4993
Copy link
Member

Question for anyone, why do these rebuilds even need to happen? Tokenizers build for the 3.9 stable ABI, so theoretically one build should work for any python version? Do we have to have separate packages?

I'm not an expert in conda builds, but my understanding is that because these are arch specific builds, and require builds with a specific Python version, they get built and packaged for that version independently. Other recipes that are noarch aren't subject to it.

Either way, the issue here is that the unit tests for the underlying package are failing on Python 3.14 because of an incompatibility with one of the dependencies. So, even if these conda package gets published, some parts of the package will propagate bugs / exceptions.

IMHO, it seems preferable to not publish this package for 3.14 until the underlying issue is resolved.

@h-vetinari
Copy link
Member

Tokenizers build for the 3.9 stable ABI, so theoretically one build should work for any python version?

That's great, thanks for the comment! You can try to follow the docs on how to do that.

@reneleonhardt
Copy link

reneleonhardt commented Nov 11, 2025

The test used code which wasn't released 3 weeks ago, a new run should fix that problem.
https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/1370818/logs/109

TestTrainFromIterators.test_datasets

>      self._batch_setitems(obj.items(), obj)
E      TypeError: Pickler._batch_setitems() takes 2 positional arguments but 3 were given

huggingface/datasets#7817
https://github.com/huggingface/datasets/releases/tag/4.4.0

@setu4993
Copy link
Member

Thanks for the nudge, @reneleonhardt. Just bumped up the version and retrying CI now.

@setu4993 setu4993 merged commit ffed798 into conda-forge:main Nov 12, 2025
33 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python314-0-1_h8166e0 branch November 12, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants