-
-
Notifications
You must be signed in to change notification settings - Fork 13
Rebuild for python 3.14 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for python 3.14 #83
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19284509137. Examine the logs at this URL for more detail. |
|
@setu4993 What's the reason you need to change the requirements? Are they already wrong in the non-migrated version? |
Yeah, the Looking through what's happening, I believe we'll need |
This reverts commit 1ea5526.
| # temp: fix until https://github.com/conda-forge/multiprocess-feedstock/pull/46 | ||
| # percolates far enough so that the solver doesn't pull in an old version anymore | ||
| - dill >=0.3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this anymore because that is from a few months years ago.
|
Blocked on: conda-forge/multiprocess-feedstock#57 |
| run: | ||
| - python | ||
| - huggingface_hub >=0.16.4,<1.0 | ||
| - huggingface_hub >=0.16.4,<2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been fixed earlier.
I think we should patch out a too-tight pin from |
I don't quite understand how that'd work, but that sounds like a better option, yes. This is also only for tests, and not a build / run dependency, so I'm also wondering if we can just skip those tests for Python 3.14. |
|
Dependencies are good now, but the tests are failing because of huggingface/datasets#7813, which is downstream of uqfoundation/dill#725. |
|
WIP fixes in: huggingface/datasets#7817, uqfoundation/dill#724. |
|
Question for anyone, why do these rebuilds even need to happen? Tokenizers build for the 3.9 stable ABI, so theoretically one build should work for any python version? Do we have to have separate packages? |
I'm not an expert in conda builds, but my understanding is that because these are arch specific builds, and require builds with a specific Python version, they get built and packaged for that version independently. Other recipes that are noarch aren't subject to it. Either way, the issue here is that the unit tests for the underlying package are failing on Python 3.14 because of an incompatibility with one of the dependencies. So, even if these conda package gets published, some parts of the package will propagate bugs / exceptions. IMHO, it seems preferable to not publish this package for 3.14 until the underlying issue is resolved. |
That's great, thanks for the comment! You can try to follow the docs on how to do that. |
|
The test used code which wasn't released 3 weeks ago, a new run should fix that problem.
huggingface/datasets#7817 |
|
Thanks for the nudge, @reneleonhardt. Just bumped up the version and retrying CI now. |
This PR has been triggered in an effort to update python314.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/18236997477 - please use this URL for debugging.