Skip to content

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Apr 15, 2024

The background is the solving failure I see in conda-forge/librsvg-feedstock#110 where vs2022 is requested as a compiler. This would make the activation package more "open" but also would pull in vs2022 probably as default?

@xhochy xhochy requested a review from isuruf as a code owner April 15, 2024 19:52
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-vetinari
Copy link
Member

This would make the activation package more "open" but also would pull in vs2022 probably as default?

AFAIU it'll pull in vs2022 if there's only {{ compiler("rust") }}; as soon as there's {{ compiler("c|cxx") }} in the build env that resolves to vs2019, it would resolve to that instead.

@xhochy xhochy merged commit e895008 into conda-forge:main Apr 16, 2024
@xhochy xhochy deleted the vs2022 branch April 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants