-
-
Notifications
You must be signed in to change notification settings - Fork 49
llvmdev v18.1.1 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmdev v18.1.1 #254
Conversation
This reverts commit 1157225.
…nda-forge-pinning 2024.01.26.23.27.14
llvmdev 18.1.0.rc1
…nda-forge-pinning 2024.02.27.06.32.03
llvmdev 18.0.1.rc4
…nda-forge-pinning 2024.03.06.07.52.39
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conda-forge/llvmdev, this should be ready, PTAL!
The main changes are:
- SOVER now contains minor, see llvm/llvm-project@91a3846 resp. the related RFC
- remove
libLLVM-<major>.${SHEXT}(as it's pointing to plainlibllvm.sowhich is in a different output for us)
|
@conda-forge/llvmdev this is green now; 18.1.0 had a bug that got fixed in 18.1.1. PTAL :) |
|
@isuruf |
|
I don't understand? Why are we removing a symlink that the project is adding? |
|
The referenced commit explains:
So for one, Seeing that there's now a "new" library name, I didn't think it's necessary to fix this, but if you want to retain the old name, we can point |
|
It's perhaps worth mentioning that I've built a functional LLVM stack for rc4 without that symlink, which is also why I don't think that we really need it. |
|
Ah, just saw that this was fixed in llvm/llvm-project@10c48a7 in the meantime. It's also on the 18.x branch already (llvm/llvm-project@4cc7a75), but while the github UI doesn't show it as released in a tag, it's actually part of 18.1.1. |
This (partially) reverts commit 9d5fb50. Possible as of 18.1.1, which contains llvm/llvm-project@4cc7a75
5c24d48 to
b177f43
Compare
|
If I understand the comments here correctly that the discussion you hab is resolved by upstream in the latest release and we could merge if CI passes? |
|
That's the plan yes :) |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Closes #257
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8171666852, please use this URL for debugging.