Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 6, 2024

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes #257

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
llvmdev 18.1.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8171666852, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conda-forge/llvmdev, this should be ready, PTAL!

The main changes are:

  • SOVER now contains minor, see llvm/llvm-project@91a3846 resp. the related RFC
  • remove libLLVM-<major>.${SHEXT} (as it's pointing to plain libllvm.so which is in a different output for us)

@h-vetinari h-vetinari changed the title llvmdev v18.1.0 llvmdev v18.1.1 Mar 9, 2024
@h-vetinari
Copy link
Member

@conda-forge/llvmdev this is green now; 18.1.0 had a bug that got fixed in 18.1.1. PTAL :)

@h-vetinari
Copy link
Member

@isuruf
Any objection to removing $PREFIX/lib/libLLVM-{{ major_ver }}${SHLIB_EXT} in the context of llvm/llvm-project@91a3846?

@isuruf
Copy link
Member

isuruf commented Mar 11, 2024

I don't understand? Why are we removing a symlink that the project is adding?

@h-vetinari
Copy link
Member

The referenced commit explains:

The main library now has a more convential library name: libLLVM.so.$major.$minor. The old library name: libLLVM-$major.so is now a symlink that points to the new library.

So for one, libLLVM-$major.so is considered "the old library name" - which in itself wouldn't be an issue for shipping it - but secondly, libLLVM-$major.so is now a symlink that points to libLLVM.so, which breaks our output-layering (as the latter is not part of libllvm18, and so the symlink appears dead and test -f ... fails).

Seeing that there's now a "new" library name, I didn't think it's necessary to fix this, but if you want to retain the old name, we can point libLLVM-$major.so to libLLVM.so.$major.$minor.

@h-vetinari
Copy link
Member

It's perhaps worth mentioning that I've built a functional LLVM stack for rc4 without that symlink, which is also why I don't think that we really need it.

@h-vetinari
Copy link
Member

h-vetinari commented Mar 11, 2024

Ah, just saw that this was fixed in llvm/llvm-project@10c48a7 in the meantime. It's also on the 18.x branch already (llvm/llvm-project@4cc7a75), but while the github UI doesn't show it as released in a tag, it's actually part of 18.1.1.

This (partially) reverts commit 9d5fb50.

Possible as of 18.1.1, which contains llvm/llvm-project@4cc7a75
@h-vetinari h-vetinari closed this Mar 14, 2024
@h-vetinari h-vetinari reopened this Mar 14, 2024
@xhochy
Copy link
Member

xhochy commented Mar 14, 2024

If I understand the comments here correctly that the discussion you hab is resolved by upstream in the latest release and we could merge if CI passes?

@h-vetinari
Copy link
Member

That's the plan yes :)

@h-vetinari h-vetinari merged commit 6fd718b into conda-forge:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants