Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Enable building tests to ensure compilation works fine#49

Merged
kkraus14 merged 5 commits intoconda-forge:mainfrom
traversaro:patch-1
Aug 30, 2023
Merged

Enable building tests to ensure compilation works fine#49
kkraus14 merged 5 commits intoconda-forge:mainfrom
traversaro:patch-1

Conversation

@traversaro
Copy link
Copy Markdown
Contributor

@traversaro traversaro commented Aug 28, 2023

See discussion in #49 . The downside is that creating new packages will last longer, but at least for bumping new versions of dependencies (like in #48 (comment)) we are sure that at least compilation works fine.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@kkraus14
Copy link
Copy Markdown
Contributor

If we're building tests I think we need to add gtest and gmock to the dependencies

@kkraus14
Copy link
Copy Markdown
Contributor

It also looks like fmt is missing

@kkraus14
Copy link
Copy Markdown
Contributor

kkraus14 commented Aug 28, 2023

Looks like RMM only supports building with CUDA >= 11.2: https://github.com/rapidsai/rmm/tree/branch-23.06#get-rmm-dependencies

https://github.com/rapidsai/rmm/blob/228330543cba4921e6b71a52dd1fa81c63921420/include/rmm/detail/dynamic_load_runtime.hpp#L94-L102

Probably need to move away from the custom conda build config and just use the versions upstream now?

@kkraus14
Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Copy Markdown
Contributor Author

Thanks @kkraus14 for fixing the PR! Hopefully this will make migration PRs easier to review.

@kkraus14
Copy link
Copy Markdown
Contributor

@conda-forge/librmm please take a look 🙂

Will merge end of day otherwise.

@kkraus14 kkraus14 merged commit f0423fb into conda-forge:main Aug 30, 2023
This was referenced Aug 30, 2023
Comment on lines -31 to -34
- thrust >=1.9.0
run:
# - spdlog >=1.8.5 # (version constraint set via run_exports)
- thrust >=1.9.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears thrust was removed. Is this intended?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since RMM exports it in include/rapids/thrust. Should probably split that off into a separate rapids-thrust package or something of the sorts in the future, but it's not a problem for now.

@jakirkham
Copy link
Copy Markdown
Member

Thanks Silvio & Keith! 🙏

Had a question above

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants