Enable building tests to ensure compilation works fine#49
Enable building tests to ensure compilation works fine#49kkraus14 merged 5 commits intoconda-forge:mainfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.08.28.12.35.38
|
If we're building tests I think we need to add gtest and gmock to the dependencies |
|
It also looks like |
|
Looks like RMM only supports building with CUDA >= 11.2: https://github.com/rapidsai/rmm/tree/branch-23.06#get-rmm-dependencies Probably need to move away from the custom conda build config and just use the versions upstream now? |
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.08.28.12.35.38
|
Thanks @kkraus14 for fixing the PR! Hopefully this will make migration PRs easier to review. |
|
@conda-forge/librmm please take a look 🙂 Will merge end of day otherwise. |
| - thrust >=1.9.0 | ||
| run: | ||
| # - spdlog >=1.8.5 # (version constraint set via run_exports) | ||
| - thrust >=1.9.0 |
There was a problem hiding this comment.
Appears thrust was removed. Is this intended?
There was a problem hiding this comment.
Yes, since RMM exports it in include/rapids/thrust. Should probably split that off into a separate rapids-thrust package or something of the sorts in the future, but it's not a problem for now.
|
Thanks Silvio & Keith! 🙏 Had a question above |
See discussion in #49 . The downside is that creating new packages will last longer, but at least for bumping new versions of dependencies (like in #48 (comment)) we are sure that at least compilation works fine.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)