Rebuild for spdlog111#37
Conversation
…nda-forge-pinning 2022.11.04.10.18.53
|
librmm is a header only library so this will pass regardless of whether there's actually code issues or not. Maybe we should enable building the tests as a sanity check in the recipe even though we won't be shipping them? |
This is a valid concern, but it is true indipendently of the spdlog111 migration (i.e. it was also true before). Could it make sense to merge anyhow to avoid blocking the migration? |
|
Think if we close, the bot considers it complete. In any event, no strong feelings here |
|
According to https://conda-forge.org/status/#spdlog111, there would be still rmm to migrate that depends on this package. Anyhow, if these will be only remain packages, we could also just close the migration without migrating these two packages. |
+1 to just closing this. I have a PR upstream to update the recipes (rapidsai/rmm#1173) and run through CI and things seem to be working nicely with spdlog 1.10, where once the migration is done I can do the same with spdlog 1.11 and then update the feedstocks. |
|
Ok, thanks! |
This PR has been triggered in an effort to update spdlog111.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3393180672, please use this URL for debugging.