Skip to content

Fix recipe#138

Open
ocefpaf wants to merge 9 commits intoconda-forge:mainfrom
ocefpaf:fix_recipe
Open

Fix recipe#138
ocefpaf wants to merge 9 commits intoconda-forge:mainfrom
ocefpaf:fix_recipe

Conversation

@ocefpaf
Copy link
Copy Markdown
Member

@ocefpaf ocefpaf commented Dec 9, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

…5.12.09.17.39.06

Other tools:
- conda-build 25.11.0
- rattler-build 0.53.0
- rattler-build-conda-compat 1.4.10
@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Dec 9, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20076484113. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Dec 9, 2025

Adding annexremote will break pip-check b/c that package should be Linux only. However, it is expected to be present in macos and Windows:

It is highly recommended to configure Git before using DataLad. Set both 'user.name' and 'user.email' configuration variables.
Traceback (most recent call last):
  File "D:\bld\datalad_1765312271104\_test_env\Scripts\git-annex-remote-datalad-archives-script.py", line 5, in <module>
    from datalad.customremotes.archives import main
  File "D:\bld\datalad_1765312271104\_test_env\lib\site-packages\datalad\customremotes\__init__.py", line 17, in <module>
    from annexremote import ProtocolError
ModuleNotFoundError: No module named 'annexremote'

"tqdm>=4.32.0",
"typing_extensions>=4.0.0; python_version < '3.11'",
- "annexremote",
+ "annexremote; platform_system=='Linux'",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK annexremote is not OS specific per se and definitely works on OSX... having said that I now notice we do not test it in its unittests anywhere else but linux. But we do test datalad across OSes, and we do not limit annexremote only to linux.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it doesn't look like, pip-check did complain about it on Windows and macos. Let me revert this patch so we can see this other error. Hold on.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Windows and macos are failing with:

+ pip check
annexremote 1.2.1 is not supported on this platform
WARNING: Tests failed for datalad-1.2.3-pyh707e725_0.conda - moving package to /Users/runner/miniforge3/conda-bld/broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants