-
-
Notifications
You must be signed in to change notification settings - Fork 40
[18.x] Add ROOT patches #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.x] Add ROOT patches #338
Conversation
…nda-forge-pinning 2025.01.28.22.50.30
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13052121337. Examine the logs at this URL for more detail. |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the patches, but the rest looks fine (assuming CI passes).
PS. Since this is purely additive configuration, a build number bump wouldn't have been necessary, but whatever. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following this patch along - it's finally been merged (llvm/llvm-project@20e9049) for llvm 20. :)
|
Thanks for taking a look! Looks like this is working locally for me now with ROOT so I'll merge it when the CI finishes.
I'm so used to ROOT lagging behind LLVM that the build hashes change for unrelated reasons by the time ROOT gets to a given version 😆 It's nice that that is no longer the case. |
It's good practice for sure, and it can still happen that hashes changes tec.. But root is definitely closing the gap, and we had just rebuilt the 18.x branch: #336 (also llvm 18 is still our default compiler stack; might be a first that root catches up to that 🥳) |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)