-
-
Notifications
You must be signed in to change notification settings - Fork 40
clangdev 17.0.1 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clangdev 17.0.1 #241
Changes from 33 commits
b6faa26
0cd990b
0704ff5
3dcae7d
c06df6b
8d205ff
a1ba32e
2fed2ea
bc1242e
a7a9822
8703c7b
1ad4de1
5d13d3a
6b634fa
8613d72
c018f30
546174a
f9aa16a
9cdf0f2
7448bc8
946e156
056e5b5
e330824
f4602f0
8b9c7dc
178fbbf
a72d48b
277f2b3
bec51e1
2794857
82a41b8
cbad9cb
5d07ff2
77ea915
3e3f771
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| From e46d9dd8f6701270b5243348ffb4b8c3430c4229 Mon Sep 17 00:00:00 2001 | ||
| From 4d6597584b90d2bc17b440dcdeff29cdc934a6dd Mon Sep 17 00:00:00 2001 | ||
| From: Isuru Fernando <[email protected]> | ||
| Date: Mon, 8 Apr 2019 16:32:17 -0500 | ||
| Subject: [PATCH 1/7] Fix sysroot detection for linux | ||
|
|
@@ -8,10 +8,10 @@ Subject: [PATCH 1/7] Fix sysroot detection for linux | |
| 1 file changed, 16 insertions(+), 4 deletions(-) | ||
|
|
||
| diff --git a/clang/lib/Driver/ToolChains/Linux.cpp b/clang/lib/Driver/ToolChains/Linux.cpp | ||
| index c6fb290ffdb..b817620a8bb 100644 | ||
| index 1ba222bf83b..ee361924b9e 100644 | ||
| --- a/clang/lib/Driver/ToolChains/Linux.cpp | ||
| +++ b/clang/lib/Driver/ToolChains/Linux.cpp | ||
| @@ -370,18 +370,30 @@ std::string Linux::computeSysRoot() const { | ||
| @@ -394,18 +394,30 @@ std::string Linux::computeSysRoot() const { | ||
| return std::string(); | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is needed here. Can you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment tries to lay out my understanding. It was necessary during the rc-phase once there was a libcxx 17, which would get pulled in by clang, which would then fail when including the C++ stdlib (because how libcxx has removed fallbacks for the old macos SDK).
In theory, the requirement
__osx>=10.13on libcxx should be enough to exclude it in this feedstock, but that's not how our CI seems to work. So I needed to bump to 10.13 here as well. I didn't distinguish between SDK and deployment target, because I thought it would be easier on the resolver if the compiler itself also has the requirement, rather than just the stdlib (which is why I had also added it to the compiler activation).I'm fine to revert this for now if you prefer. We'll just have to re-fix this feedstock one way or another as soon as libcxx 17 is live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it for now. Let's deal with it when I see an actual error.