Skip to content

Conversation

@katietz
Copy link
Contributor

@katietz katietz commented May 17, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This issue fixes that if the environment variable CONDA_BUILD_SYSROOT is defined, the '-sysroot' option passed as argument is ignored and even leads to an unused-command-line-argument warning for it.
This issue is especially problematic in cross-compiler scenario - like emscripten - where it is essential to be able to switch between native and cross' sysroot by the '-sysroot' option on demand.

As this issue is a long standing one, we might even want to backport it to older versions, but this is for now out of scope for this patch

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@katietz katietz changed the title Fix sysroot issue about CONDA_BULD_SYSROOT Fix sysroot issue about CONDA_BUILD_SYSROOT May 17, 2023
@isuruf
Copy link
Member

isuruf commented May 17, 2023

AFAIK, this was an intentional change that CONDA_BUILD_SYSROOT would override isysroot. Some software like Qt was using passing wrong -isysroot on Darwin.
However I think this is a good change even though it is backwards incompatible.

@katietz
Copy link
Contributor Author

katietz commented May 17, 2023

yeah, I think such issues should be better fixed in venture's build-system instead

@h-vetinari
Copy link
Member

Fine by me. Do we merge?

Also, how far back do you reasonably need the backports? I could do 14.x & 15.x.

@h-vetinari h-vetinari merged commit cab766f into conda-forge:main May 17, 2023
@katietz
Copy link
Contributor Author

katietz commented May 17, 2023

well, I think those both versions should be fine

@katietz katietz deleted the fix-clang-CONDA_BUILD_PREFIX branch May 17, 2023 21:55
This was referenced May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants