Add support for "initial_version" to allow auto-populating the first version#63
Merged
xtremerui merged 4 commits intoconcourse:masterfrom Feb 15, 2022
lrstanley:feature/initial-version
Merged
Add support for "initial_version" to allow auto-populating the first version#63xtremerui merged 4 commits intoconcourse:masterfrom lrstanley:feature/initial-version
xtremerui merged 4 commits intoconcourse:masterfrom
lrstanley:feature/initial-version
Conversation
Signed-off-by: Liam Stanley <me@liamstanley.io>
Signed-off-by: Liam Stanley <me@liamstanley.io>
Signed-off-by: Liam Stanley <me@liamstanley.io>
Signed-off-by: Liam Stanley <me@liamstanley.io>
Contributor
|
LGTM! Thank you for the detail documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for optionally generating the first version initially (when using
startandstop), even if it hasn't gone into the first time window yet. This is very helpful for adding the ability to manually run the job, as Concourse does not let you run a job when it has an input that's set totrigger: trueand an input with no versions yet.Does it make more sense to output something like
time.Time{}, as that obviously is more obvious that it's some kind of default timestamp -- or, output the current time like I'm doing now? I.e. if the user did setinitial_version, it's not inherently obvious if other people look at the pipeline and thetimeresource versions, that it was due to this new field.I'm not 100% sure this is the overall best solution, but to me it seems like the most straightforward way until there are enhancements to Concourse itself.