Add support for disabling service links#413
Open
mreiche wants to merge 1 commit intoconcourse:masterfrom
Open
Conversation
|
|
Member
|
Thanks for the PR! Will review sometime this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Issue
Why do we need this PR?
In some Kubernetes environments and namespaces, the concourse pods get environment variables that cannot be parsed by the entrypoint. This will result in Pod startup failures like:
This happes in the Concourse chart, when you don't use the built-in PostgreSQL chart, but another one like:
In this case, Kubernetes provides "invalid" environment variables.
Changes proposed in this pull request
This change allows administrators to disable service links environment variables in workload pods by setting:
Contributor Checklist
README.mdmasteris for changes related to the current release of theconcourse/concourse:latestimage and should be good to publish immediatelydevis for changes related to the next release of Concourse (aka unpublished code onmasterin concourse/concourse)Reviewer Checklist
masterordev)