Skip to content

Conversation

@Ohjurot
Copy link
Contributor

@Ohjurot Ohjurot commented Feb 11, 2026

Changelog: Switch to externalincludedirs to fix macos xocde build targets (Fixes #19606 )

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Switch to externalincludedirs to fix macos xocde build targets
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Ohjurot

It would be necessary to have first some test that covers this issue, that is, first a test that will be red without the fix, then green with the fix.

There are already some functional premake tests like test_premake_new_generator that can easily serve as a base for adding such a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Premake and Xcode issue

2 participants