-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a way to specify link features in CMakeConfigDeps
#19444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
memsharded
merged 12 commits into
conan-io:develop2
from
AbrilRBS:ar/cmake-link-feature
Jan 26, 2026
+176
−12
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
101f6ed
initial sketch
AbrilRBS dd3a865
Some testing
AbrilRBS e0d2391
Merge branch 'develop2' into ar/cmake-link-feature
AbrilRBS 98188b8
more links
AbrilRBS 86c0e67
Last remaining link feature for interface libraries
AbrilRBS dce23b0
Integreation tests
AbrilRBS 70b959a
Add functional test with custom link feature
AbrilRBS 3cc2694
Merge branch 'develop2' into ar/cmake-link-feature
AbrilRBS c8c1ff1
cleanup
AbrilRBS 74c62f9
Add version check
AbrilRBS bc1ee43
Update conan/tools/cmake/cmakeconfigdeps/target_configuration.py
AbrilRBS 2568292
Update conan/tools/cmake/cmakeconfigdeps/target_configuration.py
AbrilRBS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need a version check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the minimum CMake that supports this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.24 as per https://cmake.org/cmake/help/latest/variable/CMAKE_LINK_LIBRARY_USING_FEATURE.html, which is lower than CMakeConfigDeps so we're ok if I'm not mistaken?