Fix compatibility.py migration overwrite when no changes were necessary
#18882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Sep 4, 2025
| if _should_migrate_file(compatibility_file) and _should_migrate_file(cppstd_compat_file): | ||
| if os.path.exists(compatibility_file) and load(compatibility_file) != _default_compat: | ||
| if _is_migratable(compatibility_file) and _is_migratable(cppstd_compat_file): | ||
| if not os.path.exists(compatibility_file) or load(compatibility_file) != _default_compat: |
Member
Author
There was a problem hiding this comment.
This and indenting the save are the fixed logic - we want to overwrite the compatibility file only when it does not exist, or when it exsists (but it's guarded by the Conan comment, else we would not be here), and its contents are different. See the first added test for that case
memsharded
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix
compatibility.pymigration overwrite when no changes were necessary.Docs: Omit
Closes #18879 to ease pains like the reported one, even though Conan still needs write permissions to its home folder, as it will try to update the versions.txt file nevertheless