Guard against unknown languages attribute values#17512
Merged
Merged
Conversation
memsharded
approved these changes
Dec 19, 2024
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Looks good, I hope that nobody was already abusing this, even if it is experimental, but sounds good to protect early and learn.
czoido
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Error out when unknown language is used in languages attribute.
Docs: Omit
This ensures only known languages are used - Helpful when typing lowercase versions or variants of C++ by mistake. In case of C for example, this would lead to the cppstd setting unexpectedly affecting the pkgid, for which there was no warn before this
The only drawback for this is that it eliminates potential custom usages of the attribute in user customizations, but those can be solved by using any other user-specific attribute if needed