[bug] git_excluded is actually revision_mode_excluded

[silabs-raashid]

Describe the bug

When using revision_mode="scm" or "scm_folder" on a dirty repo, the error shows this message:
ERROR: Can't have a dirty repository using revision_mode='scm' and doing 'conan export', please commit the changes and run again, or use 'git_excluded = []' attribute

But there is no documentation around git_excluded. Searching for the error message took me to this line:

conan/conan/internal/api/export.py

Line 119 in cf402f7

excluded = getattr(conanfile, "revision_mode_excluded", None)

which means either the error message should change or the code should change to say which attribute is used.

How to reproduce it

1. Create a dummy repo using git and create some dummy commits
2. add a file/folder that should be packaged but shouldn't be included .gitignore
3. in your conanfile.py, use revision_mode="scm" attribute
4. run conan export-pkg .. you should see the error above.
5. edit your conanfile.py with the `git_excluded=["directory_you_added/*"], commit this.
6. repeat step 4. The error should pop-up again
7. change git_excluded to revision_mode_excluded, commit this.
8. repeat step 4. The error should be gone.

[memsharded]

Hi @silabs-raashid

Thanks for the feedback.

I think the documentation in https://docs.conan.io/2/reference/conanfile/attributes.html#revision-mode
points to:

then it is possible to exclude them from the check with the ``core.scm:excluded``
configuration, which is a list of patterns (fnmatch) to exclude.

So the configuration is called core.scm:excluded, not git_excluded, it is true that the error message is incorrect, lets fix that.

[silabs-raashid]

Thank you!

[memsharded]

#19232 has closed this ticket (it will be released in next Conan 2.23), but do not hesitate to open new tickets for any further question or issue, thanks for the feedback!