[question] [workspace] AssertionError: Node Editable

[AneekCN]

What is your question?

I am encountering the following error with workspaces. Sorry, I am not able to share repro steps as this involves some proprietary packages. My workspace setup contains an application package and 2 shared libraries. This error is produced as a result of conan workspace super-install --profile:host default --profile:build default -b=outdated -b=missing. I am looking for guidance to debug this issue. Thanks!

...
ERROR: Traceback (most recent call last):
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\cli\cli.py", line 297, in main
    cli.run(args)
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\cli\cli.py", line 193, in run
    command.run(self._conan_api, args[0][1:])
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\cli\command.py", line 199, in run
    sub.run(conan_api, parser, *args)
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\cli\command.py", line 217, in run
    info = self._method(conan_api, parent_parser, self._parser, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\cli\commands\workspace.py", line 228, in workspace_super_install
    conan_api.graph.analyze_binaries(ws_graph, args.build, remotes=remotes, update=args.update,
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\api\subapi\graph.py", line 211, in analyze_binaries
    binaries_analyzer.evaluate_graph(graph, build_mode, lockfile, remotes, update,
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\graph_binaries.py", line 445, in evaluate_graph
    self._evaluate_package_id(node, config_version)
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\graph_binaries.py", line 402, in _evaluate_package_id
    compute_package_id(node, self._modes, config_version, self._hook_manager)
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\compute_pid.py", line 27, in compute_package_id
    req_info = RequirementInfo(dep_node.pref.ref, dep_node.pref.package_id,
                               ^^^^^^^^^^^^^
  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\graph.py", line 249, in pref
    assert self.ref is not None and self.package_id is not None, "Node %s" % self.recipe
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Node Editable

ERROR: Node Editable

Have you read the CONTRIBUTING guide?

• I've read the CONTRIBUTING guide

[memsharded]

Hi @AneekCN

Thanks for the feedback.
It can be a bit challenging without reproduction steps, but lets try the following.

It seems that this is happening while trying to compute the package_id of something, that happens to have dependencies as editables. Then:

• It would help to have the full output of the command, before that stack trace.
• Then, the definition of the workspace (like the output of conan workspace info or the workspace files)
• Is it possible that there are some Editable packages that are defined globally and not belonging to the workspace?
• Add a couple of prints just before:

  File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\graph.py", line 249, in pref
      print("REF: ", self.ref)
      print("PACKAGE_ID: ", self.package_id)
      assert self.ref is not None and self.package_id is not None, "Node %s" % self.recipe

  to try to understand better (I think is the package_id that is None, but better double check)

[AneekCN]

Thanks for helping with this.

1. The trace, trimmed down to hopefully just the relevant bits. There are ~100 packages in the dependency tree so the output was quite long!
   workspace_setup_debug.txt

2. workspace info

❯ conan workspace info
WARN: Workspace found: D:\venv\atlas-async\workspace
WARN: Workspace is a dev-only feature, exclusively for testing
name: super-build-workspace
folder: D:\venv\atlas-async\workspace
packages
  - path: ../aims-ui-viewport
    ref: aims-ui-viewport/1.0.5@cn/staging
  - path: ../atlas
    ref: atlas/1.42.6@cn/staging
  - path: ../cn-viewport-api
    ref: cn-viewport-api/3.0.2@cn/staging

3. I don't think there are any global editable packages. conan editable list returns nothing

❯ conan editable list
WARN: Workspace found: D:\venv\atlas-async\workspace
WARN: Workspace is a dev-only feature, exclusively for testing

4. I have the print lines inside a guard clause to minimize the output to the affected package.

[AneekCN]

I actually changed the workspace definition since the original post, and am still seeing the same issue. The workspace no longer contains the application package.

packages
  - path: ../aims-ui-viewport ( shared-library )
    ref: aims-ui-viewport/1.0.5@cn/staging
  - path: ../atlas ( shared-library )
    ref: atlas/1.42.6@cn/staging
  - path: ../cn-viewport-api ( header-library )
    ref: cn-viewport-api/3.0.2@cn/staging

[memsharded]

I am missing some information in the output log:

======== Collapsing workspace packages ========

-------- Collapsed graph --------
Graph root
    conanws.py base project Conanfile: D:\venv\atlas-async\workspace
Requirements
    ...

Can you please share that list of Requirements of the "Collapsed graph"? I am trying to understand, it seems that the package cn-viewport-api/3.0.2@cn/staging is still there somehow, though it should have been removed from the collapsed graph, as it is not an external package in the cache, but it belongs to the super-build project workspace.

Can you also check what other packages depend on cn-viewport-api/3.0.2@cn/staging and share them?

Also add another print before:

File "D:\venv\atlas-async\.venv\Lib\site-packages\conan\internal\graph\graph_binaries.py", line 445, in evaluate_graph
    print("Computing package_id of", node, node.recipe)
    self._evaluate_package_id(node, config_version)

to try to see what other package depending on cn-viewport-api/3.0.2@cn/staging is failing to compute its package_id.

Thanks!

[AneekCN]

The workspace packages are not present in the the Requirements of the "Collapsed graph".
The dependency structure is "aims-ui-viewport" -> "atlas" -> "cn-viewport-api". "aims-ui-viewport" also depends on "cn-viewport-api" via another intermediate dependency that is not in the workspace.
Adding the extra print line in evaluate_graph printed out for many other dependencies in the graph, but not for cn-viewport-api or other packages in the workspace.

If there is elsewhere we can discuss this issue, I'd be happy to share the full output of the commands. I am eager to find a fix as we are finalizing making the switch to conan2 and would like to have a workflow using workspaces sorted!

[AneekCN]

so I removed references to "cn-viewport-api" from the dependency tree of "aims-ui-viewport" so that only "atlas" depends on it which seems to circumvent the error messages. So, is the issue that intermediate packages in the dependency tree are unable to reference cn-viewport-api as an editable package?

[AneekCN]

I was able to repro this error with a minimal example

[memsharded]

Thanks very much for putting together the code.
I am trying to reproduce, but not able. I am getting:

ERROR: Package 'static-lib-example/[*]' not resolved: Version range '*' from requirement 'static-lib-example/[*]' required by 'executable-example/1.0.0' could not be resolved.

This is expected, because the conanws.yml contains only:

packages:
- path: ../executable-example
  ref: executable-example/1.0.0
- path: ../interface-lib-example
  ref: interface-lib-example/1.0.0
- path: ../shared-lib-example
  ref: shared-lib-example/1.0.0
- path: ../plugin-example
  ref: plugin-example/1.0.0

So it doesn't contain an entry for static-lib-example/[*] at all, even if the folder is there, so it is expected to not be found, as it is not defined as part of the workspace.

It seems the workspace is missing it? Can you please check it?
It might be possible that you have that package in your Conan cache as a regular dependency? Try cleaning your Conan cache.

Side note: the --build=outdated no longer exist in Conan 2. this is doing nothing, you can drop it.

[AneekCN]

I had to deliberately remove static-lib-example/[*] from the workspace to reproduce the problem. static-lib-example/[*] (not in the workspace) serves as an intermediate package that depends on an editable package, i.e. interface-lib-example/[*]. To reproduce the error you will have to stage the static-lib-example locally. I will try to enumerate the steps more clearly.

ref: https://github.com/AneekCN/conan-cmake-super-build/tree/bug/editable_error

Here is my conan profile:

[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=23
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=194
os=Windows

Setup:

> cd ..\interface-lib-example\
> conan create . 

> cd ..\static-lib-example\
> conan create . 

(optionally, doesn't change anything)
> conan remove interface-lib-example -c

> cd ..\super-build-workspace-example

Problem step:

❯ conan workspace super-install
WARN: Workspace found: D:\venv\conan2_workspaces\super-build-workspace-example
WARN: Workspace is a dev-only feature, exclusively for testing

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=23
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=194
os=Windows

Profile build:
[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.cppstd=23
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=194
os=Windows


======== Computing dependency graph ========
Graph root
    cli
Requirements
    executable-example/1.0.0 - Editable
    interface-lib-example/1.0.0 - Editable
    plugin-example/1.0.0 - Editable
    shared-lib-example/1.0.0 - Editable
    static-lib-example/1.0.0#93f3fed3b2e98d1fc8765bd7732e8a43 - Cache
Test requirements
    gtest/cci.20210126#7b8ec8c988c27b7f0769ca720054ad9f - Cache
Resolved version ranges
    gtest/[*]: gtest/cci.20210126
    static-lib-example/[*]: static-lib-example/1.0.0
Workspace 'super-build-workspace': Packages build order:
    interface-lib-example/1.0.0
    shared-lib-example/1.0.0
    plugin-example/1.0.0
    executable-example/1.0.0

======== Collapsing workspace packages ========

-------- Collapsed graph --------
Graph root
    conanws.py base project Conanfile: D:\venv\conan2_workspaces\super-build-workspace-example
Requirements
    static-lib-example/1.0.0#93f3fed3b2e98d1fc8765bd7732e8a43 - Cache
Test requirements
    gtest/cci.20210126#7b8ec8c988c27b7f0769ca720054ad9f - Cache

======== Computing necessary packages ========
Computing package_id of gtest/cci.20210126 Cache
Computing package_id of gtest/cci.20210126 Cache
Computing package_id of gtest/cci.20210126 Cache
Computing package_id of gtest/cci.20210126 Cache
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
Connecting to remote 'conancenter' anonymously
gtest/cci.20210126: Main binary package 'aa3ab44c371a678b5269aa80d8c118f02b5a700b' missing
gtest/cci.20210126: Checking 7 compatible configurations
REF:  gtest/cci.20210126
PACKAGE_ID:  a60877c6855fb97c669b0023a2106589bf9d277f
REF:  gtest/cci.20210126
PACKAGE_ID:  a60877c6855fb97c669b0023a2106589bf9d277f
gtest/cci.20210126: Found compatible package 'a60877c6855fb97c669b0023a2106589bf9d277f': compiler.cppstd=14
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
REF:  gtest/cci.20210126
PACKAGE_ID:  aa3ab44c371a678b5269aa80d8c118f02b5a700b
Computing package_id of static-lib-example/1.0.0 Cache
REF:  interface-lib-example/1.0.0
PACKAGE_ID:  None
ERROR: Traceback (most recent call last):
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\cli\cli.py", line 297, in main
    cli.run(args)
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\cli\cli.py", line 193, in run
    command.run(self._conan_api, args[0][1:])
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\cli\command.py", line 199, in run
    sub.run(conan_api, parser, *args)
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\cli\command.py", line 217, in run
    info = self._method(conan_api, parent_parser, self._parser, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\cli\commands\workspace.py", line 228, in workspace_super_install
    conan_api.graph.analyze_binaries(ws_graph, args.build, remotes=remotes, update=args.update,
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\api\subapi\graph.py", line 211, in analyze_binaries
    binaries_analyzer.evaluate_graph(graph, build_mode, lockfile, remotes, update,
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\internal\graph\graph_binaries.py", line 446, in evaluate_graph
    self._evaluate_package_id(node, config_version)
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\internal\graph\graph_binaries.py", line 402, in _evaluate_package_id
    compute_package_id(node, self._modes, config_version, self._hook_manager)
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\internal\graph\compute_pid.py", line 27, in compute_package_id
    req_info = RequirementInfo(dep_node.pref.ref, dep_node.pref.package_id,
                               ^^^^^^^^^^^^^
  File "D:\venv\conan2_workspaces\.venv\Lib\site-packages\conan\internal\graph\graph.py", line 251, in pref
    assert self.ref is not None and self.package_id is not None, "Node %s" % self.recipe
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Node Editable

ERROR: Node Editable

[memsharded]

That is great, that helps a lot.
There is a protection in the workspace that in theory should be raising an error if there are intermediate packages in teh graph that don't belong to the workspace that has dependencies in the workspace, because that is a consistency/integrity risk.
Not sure why this protection is not raising the error, but it is a good hint to investigate it.

[memsharded]

I am trying to reproduce. First I did a unit test copying your graph structure and workspace setup:

    def test_intermediate_non_editable_2(self):
        c = TestClient(light=True)

        c.save({"interface/conanfile.py": GenConanfile("interface", "0.1")
               .with_package_type("header-library"),
                "static/conanfile.py": GenConanfile("static", "0.1")
               .with_package_type("static-library").with_requires("interface/0.1"),
                "shared/conanfile.py": GenConanfile("shared", "0.1")
               .with_package_type("shared-library")
               .with_requires("interface/0.1", "static/0.1"),
                "plugin/conanfile.py": GenConanfile("plugin", "0.1")
               .with_package_type("shared-library")
               .with_requires("interface/0.1", "static/0.1", "shared/0.1"),
                "executable/conanfile.py": GenConanfile("executable", "0.1")
               .with_package_type("application")
               .with_requires("interface/0.1", "static/0.1", "shared/0.1", "plugin/0.1")})

        c.run("workspace init")
        c.run("workspace add interface")
        c.run("export static")
        c.run("workspace add shared")
        c.run("workspace add plugin")
        c.run("workspace add executable")
        c.run("workspace super-install", assert_error=True)
        print(c.out)
        assert ("ERROR: Workspace definition error. Package static/0.1 "
                "in the Conan cache has dependencies to packages" in c.out)

It passed green correctly.

So then I gave a try to your project.
Everything worked fine, in the final conan workspace install I got a clear:

ERROR: Workspace definition error. Package static-lib-example/1.0.0 in the Conan cache has dependencies to packages in the workspace: [interface-lib-example/1.0.0]

I tried also the following simplifications:

• Removed the test_package folders, in theory it should be reproducible without them (please try)
• Removed the gtest dependency for test-requires, it seems that it shouldn't be related
• Commented out the build() and package() method of the recipes
• Followed your steps
• I am still getting an error message of ERROR: Workspace definition error. Package static-lib-example/1.0.0 in the Conan cache has dependencies to packages in the workspace: [interface-lib-example/1.0.0], which is expected, as commented above, this is a situation to avoid.

Could you please try the above simplification steps and see if it still reproduces on your end (make sure you also start with a clean cache).
Also can you please double check and confirm you are on latest Conan 2.22? Many thanks!

[AneekCN]

I was using Conan 2.21
With Conan 2.22, I do get the error that you have mentioned.

Is this the desired behavior though? As far as I remember, this was not a limitation in Conan 1 workspaces.
This would be a huge impediment for us to adopt workspaces. Having to include every intermediate dependency from a tree of hundreds of packages is not feasible.

[memsharded]

Is this the desired behavior though? As far as I remember, this was not a limitation in Conan 1 workspaces.
This would be a huge impediment for us to adopt workspaces. Having to include every intermediate dependency from a tree of hundreds of packages is not feasible.

Yes, this safeguard was intended.

Note that having a package in the cache, building against a package in the workspace breaks everything, as it is linking with something that is not a Conan cache, is not reproducible, doesn't even have revisions enabled, so it cannot correctly compute the package_id of the consumer when it depends on the recipe-revision (the embedded cases).
Having intermediate packages in the Conan cache is a huge risk with a very high likelihood of producing buggy and problematic packages. If you have your setup above:

app/1.0 -> shared/1.0 -> static/1.0

Both app and static are editable in the workspace but shared/1.0 is in the cache.
If there are changes to static/1.0, then that means that shared/1.0 in the cache needs to be rebuilt to link with the static/1.0, but then that cache binary is linking something that doesn't exist as a Conan dependency at all (note that static/1.0 might have even been removed from the cache. No recipe revisions at all, so shared/1.0 cannot safely compute its package_id. This is a broken setup, if static/1.0 is in editable and app/1.0 too, then the only possibility is that shared/1.0 is editable in the workspace too.