Skip to content

Fix DirIO portability for Windows #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
Merged

Fix DirIO portability for Windows #3168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions core/src/Streamly/FileSystem/DirIO.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,12 @@
module Streamly.FileSystem.DirIO
(
-- * Configuration
#if defined(mingw32_HOST_OS) || defined(__MINGW32__)
-- | Only the default ReadOptions are supported for Windows. Please use "id"
-- as the configuration modifier.
ReadOptions
#else
ReadOptions
, followSymlinks
, ignoreMissing
, ignoreSymlinkLoops
, ignoreInaccessible
#endif

-- * Streams
, read
, readEither
Expand Down
2 changes: 2 additions & 0 deletions hie.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ cradle:
component: "test:Data.Unbox"
- path: "./test/Streamly/Test/Data/Unfold.hs"
component: "test:Data.Unfold"
- path: "./test/Streamly/Test/FileSystem/DirIO.hs"
component: "test:FileSystem.DirIO"
- path: "./test/Streamly/Test/FileSystem/Event.hs"
component: "test:FileSystem.Event"
- path: "./test/Streamly/Test/FileSystem/Event/Common.hs"
Expand Down
2 changes: 1 addition & 1 deletion test/Streamly/Test/FileSystem/DirIO.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import qualified Streamly.Internal.Unicode.Stream as Unicode (lines)
import qualified Streamly.Data.Stream.Prelude as Stream
import qualified Streamly.Data.Fold as Fold
import qualified Streamly.Data.StreamK as StreamK
import qualified Streamly.Internal.FileSystem.DirIO as Dir
import qualified Streamly.FileSystem.DirIO as Dir

import Prelude hiding (last, length)
import BenchTestLib.DirIO
Expand Down
Loading