Skip to content

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Mar 27, 2025

@ndeloof ndeloof requested a review from glours March 27, 2025 18:13
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 simple and effective enough first iteration

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the external_service branch from f48efd9 to 5282e6c Compare April 1, 2025 08:57
@ndeloof ndeloof merged commit e705dd3 into main Apr 1, 2025
15 checks passed
@ndeloof ndeloof deleted the external_service branch April 1, 2025 09:00
@rcjsuen
Copy link

rcjsuen commented May 5, 2025

In light of compose-spec/compose-spec#138 and #776, could we also add something in the description for this new attribute while it is fresh in our minds?

@glours
Copy link
Collaborator

glours commented May 5, 2025

@rcjsuen I'll do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants