schema: remove unrecognized keywords #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in passing that some of the entries inside the JSON Schema did not do anything: - under 2019-09 `id` does not mean anything (as of draft-06, it's [spelled `$id`](https://json-schema.org/draft-06/json-schema-release-notes)), and there's no need to define explicit IDs for internal references. - there is no recongized "expose" format - the `constraints` definition is never referenced and has no constraints (`service` is not a valid keyword). I've chosen a top level `$id` URI that works, but this is arbitrary and could be replaced by something less github-specific: although not a requirement, it's nice if this is a working URL. I've also added a newline at the end of the file because that's reasonably standard. This new schema should be functionally identical to the original. Signed-off-by: Roger Peppe <[email protected]> Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applied compose-spec/compose-spec#566 + some fixes by 25fe179