Skip to content

Conversation

@Vigilans
Copy link
Contributor

According to label_file's spec: compose-spec/compose-spec#546, it supports string or a list:

services:
  one:
    label_file: ./app.labels
  two:
    label_file: 
      - ./app.labels
      - ./additional.labels

But without applying transform.Canonical it only supports list format. This PR applies transformStringOrList to it to fix this.

@Vigilans Vigilans requested a review from ndeloof as a code owner December 22, 2024 06:03
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof force-pushed the vigilans/label-file-canonical branch from 48f8628 to e153dd1 Compare January 6, 2025 14:54
@ndeloof ndeloof enabled auto-merge (rebase) January 6, 2025 14:54
@ndeloof ndeloof merged commit 7f822e3 into compose-spec:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants