Skip to content

Fix uniqueItems property defined on object #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix uniqueItems property defined on object #716

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e1183
Fix uniqueItems property defined on object
AnaMManolache Nov 29, 2024
f39b841
Specify type of extra_host array items
AnaMManolache Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions schema/compose-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,9 +929,17 @@
"type": "object",
"patternProperties": {
".+": {
"type": ["string", "array"]
},
"uniqueItems": false
"oneOf": [
{
"type": "string"
},
{
"type": "array",
"items": {},
Copy link
Collaborator

@ndeloof ndeloof Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when set with an array, items are actually of type string. Schema should reflect this constraint

Copy link
Contributor Author

@AnaMManolache AnaMManolache Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this constraint now

"uniqueItems": false
}
]
}
},
"additionalProperties": false
},
Expand Down