Skip to content

Conversation

@KarelWintersky
Copy link
Contributor

Fixed incorrect path to livebook.creds file

✍️ Description

image

Real path to file, not a ~/livebook.creds

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Fixed incorrect path to livebook.creds file
@KarelWintersky KarelWintersky requested a review from a team as a code owner November 11, 2025 21:09
@github-actions github-actions bot added the json label Nov 11, 2025
@michelroegl-brunner
Copy link
Member

When did you create the LXC? In livebook-install.sh the creds get saved to ~/livebook.creds, not under /opt/livebook.

@KarelWintersky
Copy link
Contributor Author

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/livebook.sh)"
   __    _            __                __
   / /   (_)   _____  / /_  ____  ____  / /__
  / /   / / | / / _ \/ __ \/ __ \/ __ \/ //_/
 / /___/ /| |/ /  __/ /_/ / /_/ / /_/ / ,<
/_____/_/ |___/\___/_.___/\____/\____/_/|_|

  ⚙️  Using Default Settings on node blacktower
  🆔  Container ID: 103
  🖥️  Operating System: ubuntu (24.04)
  📦  Container Type: Unprivileged
  💾  Disk Size: 4 GB
  🧠  CPU Cores: 2
  🛠️  RAM Size: 1024 MiB
  🚀  Creating a Livebook LXC using the above default settings

  ✔️   Storage local (Free: 697.9GB  Used: 175.7GB) [Template]
  ✔️   Storage vmdata-local (Free: 697.9GB  Used: 175.7GB) [Container]
  ✔️   Template ubuntu-24.04-standard_24.04-2_amd64.tar.zst [local]
  ✔️   LXC Container 103 was successfully created.
  ✔️   Started LXC Container
  ✔️   Network in LXC is reachable (ping)
  ✔️   Customized LXC Container
  ✔️   Set up Container OS
  ✔️   Network Connected: 192.168.111.105
  ✔️   IPv4 Internet Connected
   ✖️   IPv6 Internet Not Connected
  ✔️   Git DNS: github.com:(✔️ ) raw.githubusercontent.com:(✔️ ) api.github.com:(✔️ ) git.community-scripts.org:(✔️ )
⠙ Updating Container OS
...
  ✔️   Updated Container OS
  ✔️   Installed Dependencies
  ✔️   Created livebook user
   💡   WARNING: This script will run an external installer from a third-party source (https://elixir-lang.org).
   💡   The following code is NOT maintained or audited by our repository.
   💡   If you have any doubts or concerns, please review the installer code before proceeding:
         🌐   →  https://elixir-lang.org/install.sh

      Do you want to continue? [y/N]: y

  ✔️   Installed Erlang 28.1.1 and Elixir 1.19.2-otp-28
  ✔️   Installed Livebook
  ✔️   Customized Container
  ✔️   Cleaned Up
  🚀  Livebook setup has been successfully initialized!
  💡   Access it using the following URL:
    🌐  http://192.168.111.105:8080

root@blacktower:~# pct enter 103
root@livebook:~#
root@livebook:~# cat ~/livebook.creds
cat: /root/livebook.creds: No such file or directory

root@livebook:~# cat /opt/livebook/livebook.creds
Livebook-Credentials
Livebook Password: S48YD3UdgTi2ykol

@KarelWintersky
Copy link
Contributor Author

KarelWintersky commented Nov 12, 2025

root@livebook:~# ls -la /opt/livebook/
total 40
drwxr-xr-x 7 livebook livebook 4096 Nov 12 10:52 .
drwxr-xr-x 3 root     root     4096 Nov 12 10:50 ..
drwxr-xr-x 3 livebook livebook 4096 Nov 12 10:50 .cache
drwxr-xr-x 4 livebook livebook 4096 Nov 12 10:50 .elixir-install
-rw-r--r-- 1 livebook livebook  491 Nov 12 10:52 .env
-r-------- 1 livebook livebook   20 Nov 12 00:00 .erlang.cookie
drwxr-xr-x 3 livebook livebook 4096 Nov 12 10:51 .hex
-rw-r--r-- 1 livebook livebook   57 Nov 12 10:52 livebook.creds
drwxr-xr-x 3 livebook livebook 4096 Nov 12 10:52 .local
drwxr-xr-x 5 livebook livebook 4096 Nov 12 10:52 .mix

root@livebook:~# ls -la /home/
total 8
drwxr-xr-x  2 root root 4096 Apr 22  2024 .
drwxr-xr-x 22 root root 4096 Nov 12 10:50 ..

@MickLesk
Copy link
Member

its correct @michelroegl-brunner the tilde expand to userhome, but this tool isnt installed as root, so the home is "/opt/livebook" at this moment

@MickLesk MickLesk changed the title Update livebook.json livebook: update dir of creds file in website Nov 12, 2025
Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well i missed that.

@michelroegl-brunner michelroegl-brunner merged commit 1b6d26a into community-scripts:main Nov 12, 2025
3 checks passed
@KarelWintersky KarelWintersky deleted the patch-1 branch November 12, 2025 08:51
michelroegl-brunner pushed a commit that referenced this pull request Nov 12, 2025
Fixed incorrect path to livebook.creds file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants