Add support for newer GHCs#2
Merged
snoyberg merged 5 commits intocommercialhaskell:masterfrom Apr 9, 2021
Merged
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for GHC 8.10 and 9.0.1 (8.8 already worked).
I've added some tests for 8.8, 8.10 and 9.0. By the way I've added them manually because the nix-shell script didn't work: the hash for nixpkgs is wrong; if we set it right it doesn't contain newer compilers; if we update it it doesn't contain older compilers. I've used ghcup instead.
I've added some tracing which is disabled by default but I've left it as it has been very useful and could be useful in the future.