fix(ts-sdk): add return type for shipping method #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 128 128
Lines 3286 3286
Branches 758 758
=======================================
Hits 3241 3241
Misses 41 41
Partials 4 4 Continue to review full report at Codecov.
|
daern91
suggested changes
Apr 28, 2020
| action: 'setKey', | ||
| key: 'key' | ||
| } | ||
| key: 'key', |
Contributor
There was a problem hiding this comment.
hmm these formatting changes shouldnt be here, could you please run yarn format inside the root folder to fix them?
Contributor
Author
There was a problem hiding this comment.
i run yarn format inside the root folder, but i got them still, i dont know why i got them
daern91
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add return type for shipping method sub endpoints
Description
This PR tries to fix the lack of return type for sub shipping method endpoints reported by our user in #1536