feat(request-builder): add orderNumber support on order service #1515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 128 128
Lines 3275 3281 +6
Branches 754 757 +3
=======================================
+ Hits 3230 3236 +6
Misses 41 41
Partials 4 4
Continue to review full report at Codecov.
|
daern91
left a comment
daern91
left a comment
There was a problem hiding this comment.
Congrats on your first PR! 💯 🥇
It all looks good to me, and I just added a few nitpicks
| expect(service.params.customerId).toBe('myCustomer') | ||
| }) | ||
|
|
||
| test('should set the orderNumber param', () => { |
There was a problem hiding this comment.
nitpick: It would be nice to move this block down below the test for customerId so they are all organized together.
There was a problem hiding this comment.
I've moved it, take another look.
|
|
||
| test('should throw if orderNumber is missing', () => { | ||
| expect(() => service.byOrderNumber()).toThrow( | ||
| /Required argument for `byOrderNumber` is missing or invalid/ |
There was a problem hiding this comment.
| /Required argument for `byOrderNumber` is missing or invalid/ | |
| /Required argument for `byOrderNumber` is missing/ |
another ocd nitpick from me 😆
There was a problem hiding this comment.
lol, this is fixed now
daern91
changed the title
jherey
force-pushed
the
1292-add-byordernumber-support-on-order-service
branch
from
19ed3d8 to
9f874c4
Compare
Summary
Add order number support on order service
Description
byOrderNumber