Remember the generated stream_id across batches of events being appeneded.#289
Merged
jwilger merged 3 commits intocommanded:masterfrom Oct 21, 2024
Conversation
And we've missed seeing some failing tests by not running them. See issue commanded#283
So that subsequent batches update instead of trying to insert and fail
drteeth
force-pushed
the
283-eventstoreappend_to_stream-is-not-able-to-append-more-than-1000-events-to-a-new-stream
branch
from
39f429b to
0956c4c
Compare
drteeth
commented
Sep 19, 2024
| {:ok, %Postgrex.Result{num_rows: 0}} -> {:error, :not_found} | ||
| {:ok, %Postgrex.Result{}} -> :ok | ||
| {:error, error} -> handle_error(error) | ||
| {:ok, %Postgrex.Result{num_rows: 0}} -> |
Contributor
Author
There was a problem hiding this comment.
This branch can no longer be hit, and whatever case it was guarding against will change. There is no test that was covering this.
cdegroot
approved these changes
Sep 30, 2024
Contributor
|
Looks a bit better than #283 so let's merge this and close that one. |
jwilger
approved these changes
Oct 21, 2024
drteeth
deleted the
283-eventstoreappend_to_stream-is-not-able-to-append-more-than-1000-events-to-a-new-stream
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #283
By returning and remembering
stream_idcreated in the first batch, then subsequent batches no longer fail with a duplicate stream_uuid constraint error.This has been a long standing issue as mentioned in the issue. It was hidden by excluding
:slowtests by default. This PR also includes slow tests by default. The test run goes from about 30s to 60s on my machine.I think we can close #285 in favour of this one.
Big thanks to @thomasdziedzic for finding this one.