Skip to content

feat: allow using http-client feature in wasm32-unknown-unknown target #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow using http-client feature in wasm32-unknown-unknown target #1485

wants to merge 2 commits into from

Conversation

@jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jan 13, 2025 •
edited
Loading

This PR allows using the http-client and thus the Client under wasm32-unknown-unknown target. Previously this wasn't possible due to rt-multi-thread tokio feature being pulled (that is not supported on that target) and the async_trait enforcing the Send bound.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jstuczyn