Skip to content

Conversation

@thanethomson
Copy link
Contributor

📖 CHANGELOG

The changelog includes all changes added from v0.23.0, including "frontports" from v0.23.x. Since there's effectively a lot of repetition in the changelogs between v0.23.x and v0.24.x now, we have a few options when it comes time to retire v0.23.x:

  1. Just merge all v0.23.x changelog entries into the changelog on master. This will necessarily include a lot of duplication between v0.23.x releases and the v0.24.0-pre.1 release.
  2. Drop all changes from v0.23.1 before v0.24.0.
  3. Reformat the v0.24.x changelog to deduplicate the entries that already effectively appeared in the v0.23.x series.

I'm currently in favor of option (1) because it's the most accurate one as to what's changed in each release. Are there other options that could be better? Or do others have different preferences?

Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #1078 (8296618) into master (23a8950) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1078     +/-   ##
========================================
- Coverage    64.7%   64.7%   -0.1%     
========================================
  Files         238     238             
  Lines       20592   20592             
========================================
- Hits        13332   13329      -3     
- Misses       7260    7263      +3     
Impacted Files Coverage Δ
light-client/src/lib.rs 100.0% <ø> (ø)
proto/src/lib.rs 100.0% <ø> (ø)
tendermint/src/lib.rs 100.0% <ø> (ø)
testgen/src/vote.rs 84.0% <0.0%> (-0.9%) ⬇️
testgen/src/validator.rs 86.7% <0.0%> (-0.8%) ⬇️
tendermint/src/node.rs 63.5% <0.0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a8950...8296618. Read the comment docs.

@thanethomson thanethomson marked this pull request as ready for review January 13, 2022 01:21
mzabaluev
mzabaluev previously approved these changes Jan 13, 2022
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Thane Thomson <[email protected]>
@thanethomson thanethomson merged commit 38668f1 into master Jan 14, 2022
@thanethomson thanethomson deleted the release/v0.24.0-pre.1 branch January 14, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants