Absorb rust-abci

[tac0turtle]

Discuss absorbing the rust-abci repo as its own crate within this repo.

[tomtau]

that could be good for unifying some of the amino/protobuf types

[ebuchman]

seems like a good idea - we should add something about this to the ADR-001: #28

[davebryson]

It feels like pulling ABCI into this repo would just complicate things a bit. Unless this repo is slowly moving from just a client to a full blown tendermint core implementation...which would be really cool btw...

[tomtau]

Yeah, it can be a bit complicated at the moment, as the protobuf generated definitions versus the nice hand-written RPC types don't quite match up

[tarcieri]

For what it's worth, I'd prefer generated RPC types for use in the KMS. I think the current handwritten ones are a bit overcomplicated, and using protos means they won't diverge.

[tomtau]

I think that could work -- one would need to modify https://github.com/tendermint/rust-abci/blob/develop/build.rs

so that the generated ABCI types derive serde deserialisers etc.
https://docs.rs/protobuf-codegen/2.8.1/protobuf_codegen/struct.Customize.html#structfield.serde_derive

One thing to consider would be separating out the ABCI types into a dedicated rust-abci-types crate (versus keeping it with the ABCI server implementation)

[ebuchman]

Ideally we can use proto as the canonical definition for all the types, and re-use them both for ABCI and the RPC.

This won't 100% work for everything yet as there are still some things that depend on amino encoding with prefixes in the RPC (namely pubkeys, but I think that's it). But we plan to transition even amino interfaces to proper proto3 wellknowntype Any soon, so this should be fully possible. Definitely something to work towards.

Unless this repo is slowly moving from just a client to a full blown tendermint core implementation...which would be really cool btw...

That's the plan!

[tac0turtle]

Would like to revisit this issue. Should a new ADR be written or an amendment be made to adr-001?

[liamsi]

@marbar3778 an adr or even a draft PR instead (or in parallel with that adr) would be awesome.