-
Notifications
You must be signed in to change notification settings - Fork 6
fix(uninstall): fix issues with uninstalling manifest-only drivers #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(uninstall): fix issues with uninstalling manifest-only drivers #5
Conversation
8d0f921 to
8b82752
Compare
|
Ready for a review. This now uses Clean on the path and I was able to test the new logic in config.UninstallDriverShared. |
|
Looks like there's still issues with the windows tests |
|
I'm seeing if I can figure out what's going on in CI by surfacing the error (which I should have done originally). |
|
Hrm,
I may need to log into my Windows machine to see if installing a manifest-only driver works on Windows. |
path.base isn't for file paths, see https://pkg.go.dev/path.
|
Looks good now @zeroshade. |
|
Thanks for the review @zeroshade! |
This primarily fixes a bug with dbc uninstall for manifest-only drivers where the extra folder we install alongside the driver manifest wasn't being removed. I also factored out the common logic related to removing the driver shared library and added some defensive checks to limit the impact of a maliciously-crafted driver manifest.
Ref #15