Skip to content

Conversation

@zeroshade
Copy link
Member

@zeroshade zeroshade commented Sep 17, 2025

closes #19

@amoeba
Copy link
Member

amoeba commented Sep 17, 2025

I bet this fixes the direct issue but I think there's a fundamental issue we might want to address since this happens elsewhere if you look closely. See how this cuts off?

Screenshot 2025-09-17 at 2 19 01 PM

@zeroshade
Copy link
Member Author

Hmm, good point. Let me see if there's any general option I can pass to bubbletea to handle this

@amoeba
Copy link
Member

amoeba commented Sep 17, 2025

I noticed that the charmbracelet team has an example where we add a "finalOutput" member to the cmd struct (alongside status) and then have the root cmd print the finalOutput. I started on this in amoeba@58d0803.

@amoeba
Copy link
Member

amoeba commented Sep 17, 2025

@zeroshade
Copy link
Member Author

Ah, you mean shift the output for when we're done to after the return instead of as part of the View method?

@amoeba
Copy link
Member

amoeba commented Sep 17, 2025

Yep. It cleanly separates the output into two categories. Requires quite a bit of change I think.

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Thanks.

@zeroshade zeroshade merged commit f926149 into main Sep 17, 2025
7 checks passed
@zeroshade zeroshade deleted the wrap-output branch September 17, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issue with truncated post-install message

3 participants