fix(tests): add prog.Wait in test #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll try re-running the flaky jobs several times here ⌛ |
ianmcook
approved these changes
Oct 23, 2025
Member
ianmcook
left a comment
ianmcook
left a comment
There was a problem hiding this comment.
I re-ran the tests four times, and there were no failures. So it seems statistically probable that this fixed it!
Member
|
Is this flakiness what we had hoped to fix with this? https://github.com/columnar-tech/dbc/actions/runs/18792503522/job/53625842071?pr=154 |
Member
Author
|
Hmm, so we fixed the flakiness on macOS but not on Windows -_- oy |
Member
|
Worth trying to improve things, at the very least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might hopefully fix the flakiness?