fix: add workaround for driver manager venv path bug #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Changing the repo visibility broke the link between the main repo and my fork so I had to re-create #92. |
Member
Author
I think I'd rather keep it for now. Over time if we expand what tests are done I imagine we can change this. |
zeroshade
reviewed
Sep 26, 2025
.github/workflows/integration.yml
Outdated
|
|
||
| - name: Build dbc | ||
| run: | | ||
| go build -o dbc ./cmd/dbc |
Member
There was a problem hiding this comment.
are we using the -o so that it doesn't call it dbc.exe on windows? otherwise you can just remove the -o argument entirely since by default it'll use dbc as the name since that's the package name.
Member
Author
There was a problem hiding this comment.
Ah, nice. I just always run it with -o. Removed in 30d3b4c and will watch CI.
zeroshade
approved these changes
Sep 26, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
just the one comment but otherwise looks good!
Member
Author
|
Thanks. Once CI passes I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a bug we identified with the 1.8.0 driver managers when using virtual environments. They are supposed to locate drivers in
$VIRTUAL_ENV/etc/adbc/driversbut they look in$VIRTUAL_ENV/etc/adbc/. There may be a patch release soon to fix this but, in the mean time, we can work around this by symlinking manifests from$VIRTUAL_ENV/etc/adbc/driversto$VIRTUAL_ENV/etc/adbc/. The manifests use absolute paths so it's fine.This PR also adds an integration workflow which is how I tested my change. I don't think we want to run it on every single commit to the repo so we might discuss here when we might want to run something like this or if we want to run it in another repo.