Fix compilation issues on MacOS #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
approved these changes
Jun 11, 2025
Contributor
|
Thank you. |
Contributor
Author
|
@ahojnnes, thanks for accepting my contribution. Some of the checks seem stuck in the ‘Expected’ state. Could you help trigger them? |
uptycs-rmack
pushed a commit
to uptycs-rmack/glomap
that referenced
this pull request
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #184, there's a problem in GLOMAP's macOS compilation pipeline due to COLMAP syntax inside its code. This problem is easily solvable by fetching and applying the recent commit colmap/colmap@a586e7c proposed in COLMAP's repository. This pull request has implemented this patching process automatically inside GLOMAP's CMake, and I have tested it on my end.