Skip to content

Conversation

@tiberiuichim
Copy link
Member

No description provided.

Copy link

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral erral self-requested a review September 30, 2022 06:16
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but I don't know if the naming of the option is clear enough "Use labels as placeholders", perhaps it is worth to add a description saying "labels will be hidden and the content of the label will be shown as placeholder".

Moreover it would be nice (but I don't know if that's possible), that when the option is checked the preview of the form changes to reflect the made option, this way the end user can understand the option better.

title={label}
title={labelsAsPlaceholders ? '' : label}
placeholder={labelsAsPlaceholders ? label : ''}
description={description}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 'columns' prop here too?

name={name}
title={label}
title={labelsAsPlaceholders ? '' : label}
description={description}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 'columns' prop here too?

title={label}
title={labelsAsPlaceholders ? '' : label}
placeholder={labelsAsPlaceholders ? label : ''}
description={description}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 'columns' prop here too?

@giuliaghisini
Copy link
Contributor

I like this, but I don't know if the naming of the option is clear enough "Use labels as placeholders", perhaps it is worth to add a description saying "labels will be hidden and the content of the label will be shown as placeholder".

Moreover it would be nice (but I don't know if that's possible), that when the option is checked the preview of the form changes to reflect the made option, this way the end user can understand the option better.

agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants