-
-
Notifications
You must be signed in to change notification settings - Fork 186
Add RFC 9253 compatibility #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19131981244Details
💛 - Coveralls |
38f4c08 to
bc3d74b
Compare
|
This is ready for review when you have time. No pressure ;) |
| attendees: Optional[list[vCalAddress]] = None, | ||
| concepts: list[str | vUri] | str | vUri | None = None, | ||
| description: Optional[str] = None, | ||
| links: list[str | vXmlReference | vUri | vUid] | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why must this be a list or none instead of accepting a single element like the other ones?
| cls, | ||
| /, | ||
| attendees: Optional[list[vCalAddress]] = None, | ||
| concepts: list[str | vUri] | str | vUri | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use type aliasses like for related_to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I will look into this..
Closes issue
Replace
ISSUE_NUMBERwith the issue number that your pull request fixes. Then GitHub will link and automatically close the related issue.Description
This intends to solve the issue
Checklist
Event.conferencesandEvent.linksCHANGES.rst.docs/credits.rstas a contributor in this pull request or have done so previously.Still TODO:
Documentation Review guidance
Classes modified:
Additional information
www.rfc-editor.org/rfc/rfc9253.html