Skip to content

Conversation

@rotu
Copy link
Contributor

@rotu rotu commented Dec 10, 2023

Previously the sanity checks in yarn run depcruise would fail for two reasons:

  1. Benchmark scripts were mistakenly not marked as development-only and were using development dependencies
  2. Test code was referencing the @jest/globals package, which was an implicit requirement (via jest)

Now this script should pass

@netlify
Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit de7caab
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/657514bd8367880009be2e32
😎 Deploy Preview https://deploy-preview-3037--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks colinhacks merged commit 8835cd3 into colinhacks:master Apr 16, 2024
@rotu rotu deleted the civil-hamster branch April 17, 2024 03:05
@colinhacks colinhacks mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants