Add argument to set .cargo/config.toml path #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
luca-della-vedova
left a comment
luca-della-vedova
left a comment
There was a problem hiding this comment.
I'm not opposed to this feature, there will probably be some bikeshedding on the argument name (imho config path sounds a bit too generic) and comments / grammar, but to start with can you get the CI to be green? Most of them are flake8 issues but there are some actual test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the configuration is stored at the ' 'colcon workspace' top level directory.
We faced an issue when the source code is in another location and when we use a symbolink link. In this case the config.toml generated in the colcon_ws is not found.
This option permits to set a custom place for the generated config.toml