Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Remove fallback to coin.Symbol when loading portfolio. Remove deprecated favoritesBySymbol.#219

Merged
lyricnz merged 2 commits intocointop-sh:masterfrom
lyricnz:feature/remove-symbol-fallback
Oct 12, 2021
Merged

Remove fallback to coin.Symbol when loading portfolio. Remove deprecated favoritesBySymbol.#219
lyricnz merged 2 commits intocointop-sh:masterfrom
lyricnz:feature/remove-symbol-fallback

Conversation

@lyricnz
Copy link
Collaborator

@lyricnz lyricnz commented Oct 12, 2021

As mentioned in issue #214

@lyricnz lyricnz requested a review from miguelmota October 12, 2021 02:13
Copy link
Member

@miguelmota miguelmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lyricnz lyricnz merged commit da06d5e into cointop-sh:master Oct 12, 2021
@lyricnz lyricnz deleted the feature/remove-symbol-fallback branch October 12, 2021 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants