docs(svm): document facilitator fee payer guards #546
Conversation
… payer validation tests and fix mocks to Instruction accounts array; chore: align high-level tests with signer-aware verification
✅ Heimdall Review Status
|
|
@notorious-d-e-v is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
| verifyComputePriceInstruction(transactionMessage.instructions[1]); | ||
|
|
||
| // verify that the fee payer is not included in any instruction's accounts | ||
| transactionMessage.instructions.forEach(instruction => { |
There was a problem hiding this comment.
@notorious-d-e-v can we do this check right before we verify any instructions? So start to do it on line 201. I feel before we verify any instructions it's good to check the fee payer first.
Also, is there anything malicious that can be done with the fee payer being an account in the compute limit and price instructions? Not sure if we really have to check them. That being said, since the instructions list we are searching in is a fixed size, don't see this increasing latency with a low constant factor.
CarsonRoscoe
left a comment
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Merging for the sake of the fix, but I do agree with Marcin's comment about moving it up in a follow
4 participants
Description
tests(svm): add fee payer validation tests and fix mocks to Instruction accounts array; chore: align high-level tests with signer-aware verification
Tests
All pass. New tests to verify that instructions with facilitator address as authority fail.
Checklist