-
Notifications
You must be signed in to change notification settings - Fork 654
feat: add USDC for Lisk Test/Mainnet #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@dante4rt is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Lisk and Lisk Sepolia networks to the x402 codebase, enabling USDC token interactions on these EVM-compatible chains.
Key Changes:
- Added Lisk (mainnet) and Lisk Sepolia (testnet) to the list of supported EVM networks
- Configured USDC token addresses and names for both networks
- Integrated Lisk chain definitions into the wallet utilities
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| typescript/packages/x402/src/types/shared/network.ts | Added Lisk networks to the schema, supported networks list, and chain ID mappings |
| typescript/packages/x402/src/types/shared/evm/wallet.ts | Imported Lisk chain definitions and added case handlers for chain resolution |
| typescript/packages/x402/src/types/shared/evm/config.ts | Added USDC token configuration for both Lisk networks with addresses and names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @CarsonRoscoe, could you please review this PR? Thanks! |
Description
This pull request adds support for the Lisk and Lisk Sepolia EVM networks across the codebase. The changes ensure these networks are recognized, properly mapped, and have their USDC token information configured.
Lisk network support:
"lisk"and"lisk-sepolia"to the list of supported EVM networks inNetworkSchema,SupportedEVMNetworks, and mapped their network names to chain IDs inEvmNetworkToChainId(network.ts). [1] [2] [3]configobject (config.ts).Wallet and chain integration:
liskandliskSepoliachain definitions and updatedgetChainFromNetworkto support both new networks (wallet.ts). [1] [2]Tests
The changes were verified with the following commands, and all tests passed.
Checklist