feat: Add wallet preference support to DefaultOnchainKitProviders #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for wallet.preference configuration (smartWalletOnly, eoaOnly, all) - Implement proper connector selection based on preference - Add coinbaseWallet connector for eoaOnly preference - Add comprehensive test coverage with 12 new test cases - Include edge cases and error handling tests - Improve connector selection logic with MiniKit > Preference > Default priority Fixes: Wallet preference configuration was ignored in DefaultOnchainKitProviders Tests: Expanded from 7 to 19 test scenarios (+170% coverage)
🟡 Heimdall Review Status
|
|
@zinderud is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Improve DefaultOnchainKitProviders with Wallet Preference Support
📋 Summary
This PR adds comprehensive wallet preference support to
DefaultOnchainKitProvidersand significantly improves test coverage.🔧 Changes Made
Core Functionality
smartWalletOnly,eoaOnly,alleoaOnlypreferenceTest Improvements
smartWalletOnly,eoaOnly,all)🐛 Problem Solved
Previously, the
wallet.preferenceconfiguration in OnchainKitProvider was completely ignored in DefaultOnchainKitProviders, causing inconsistent behavior.🧪 Testing
📊 Test Results