Skip to content

[BUG][reconciler] Handle Skipped Reconciliations Correctly #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020
Merged

[BUG][reconciler] Handle Skipped Reconciliations Correctly #266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d785a1
Make sure to continue after skipping
patrick-ogrady Dec 4, 2020
37832a5
fix graceful shutdown
patrick-ogrady Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ func (r *Reconciler) queueChanges(
); err != nil {
return err
}

continue
}

// Add all seen accounts to inactive reconciler queue.
Expand Down Expand Up @@ -825,6 +827,7 @@ func (r *Reconciler) reconcileInactiveAccounts( // nolint:gocognit
shouldAttempt, head := r.shouldAttemptInactiveReconciliation(ctx)
if !shouldAttempt {
r.queueMap.Unlock(key)
r.inactiveQueueMutex.Unlock()
time.Sleep(inactiveReconciliationSleep)
continue
}
Expand Down