Implements Mempool endpoint #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@shrimalmadhur could you review this PR if possible, please? |
shrimalmadhur
approved these changes
Jan 18, 2022
shrimalmadhur
approved these changes
Jan 18, 2022
Contributor
Author
|
@shrimalmadhur do I need to do something more to merge? Btw, I don't have access to the merge button |
shrimalmadhur
approved these changes
Jan 18, 2022
Contributor
@thepabloaguilar there is problem on our side. I am trying to fix it. You don't have to do anything. will circle back once I fix it. |
Contributor
Author
|
Ok, thanks a lot @shrimalmadhur |
shrimalmadhur
approved these changes
Jan 19, 2022
shrimalmadhur
approved these changes
Jan 20, 2022
shrimalmadhur
approved these changes
Jan 20, 2022
shrimalmadhur
approved these changes
Jan 24, 2022
shrimalmadhur
approved these changes
Jan 24, 2022
Contributor
|
@thepabloaguilar merged it now. apologies for the delay. we had some internal issues with approval. |
Contributor
Author
|
No worries @shrimalmadhur, thanks for the support! Btw, there's another approved PR of mine #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Motivation
Implementing Mempool endpoint.
Solution
To get the transactions in "memory" I've used the
txpool_contentmethod which returns all pending and queued transactions.More about on https://geth.ethereum.org/docs/rpc/ns-txpool#txpool_content