handle EIP-1559 blocks & fee burning #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @roberto-bayardo , can you fix the linting issue in this? otherwise this PR looks good to me. Thanks |
roberto-bayardo
force-pushed
the
master
branch
2 times, most recently
from
fdc336e to
7a7479d
Compare
roberto-bayardo
force-pushed
the
master
branch
from
7a7479d to
b24aaa8
Compare
shrimalmadhur
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the london fork, transaction fees are at least in part burnt and are computed differently than previously. This PR computes proper tx fees and burnt fee amounts for transactions in EIP-1559 blocks.
Testing: I have added a test case that involves a real post-london block from mainnet that contains 6 EIP-1559 type transactions and 1 legacy transaction. I have confirmed that the values appearing in the block_response FEE operations match the actual fee sent to the miner & burnt as reported in etherscan, for all 7 of the transactions.