construction/payloads: Transaction input field should be data accordi… #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to Ethereum spec
akramhussein
commented
Jul 24, 2021
services/types.go
Outdated
| } | ||
|
|
||
| input, err := hexutil.Decode(tw.Input) | ||
| data_, err := hexutil.Decode(tw.Data) |
Contributor
Author
There was a problem hiding this comment.
The variable name is already taken - not sure what an appropriate alternative might be?
akramhussein
commented
Jul 24, 2021
services/types.go
Outdated
| t.To = tw.To | ||
| t.Value = value | ||
| t.Input = input | ||
| t.Data = data_ |
shrimalmadhur
approved these changes
Jul 26, 2021
Contributor
shrimalmadhur
left a comment
shrimalmadhur
left a comment
There was a problem hiding this comment.
twData name looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Note: This PR replaces #47. I deleted the fork and forgot about the link so had to re-instated.
Motivation
When using the endpoint
construction/payloadstheunsigned_transactionpayload is invalid for passing to a signer. Per #46 references it should bedatawhen submitting to a signer andinputis part of the response.Solution
Rename
inputtodataon thetransactionandtransactionWirestructs.Open questions
None