Add support for additional testnets (Rinkeby and Görli) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration TESTNET flag for backwards compatibility.
septerr
approved these changes
Jun 11, 2021
Contributor
septerr
left a comment
septerr
left a comment
There was a problem hiding this comment.
thank you for making this improvement!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ethereum does not have 1 de-facto testnet. There are in fact several such as
Ropsten,Rinkeby,Görlietc. Each network has its own purpose and often developers must test on different networks for a variety of reasons such as where dApps are deployed to.This PR adds support for additional networks (Rinkeby and Görli), while maintaining backwards compatibility by defaulting
NETWORK=TESTNETtoRopstenwhich is how it currently behaves.Solution
Testnet...structs toRopsten...to be clear which network configuration it points to.TESTNETtoROPSTENconfigurationRinkebyandGoerli(Görli)Open questions
None