Override log and table sizes for badger options #198
Conversation
| // this value is, the larger database transactions | ||
| // storage can handle (~15% of the max table size | ||
| // == max commit size). It is only applied if MemoryLimitDisabled is true. | ||
| MaxTableSize int64 `json:"max_table_size,omitempty"` |
There was a problem hiding this comment.
let's do these as *int64...we are going to do a migration to this so that we don't infer 0 as the default
| DefaultBlockBroadcastLimit = 5 | ||
| DefaultStatusPort = 9090 | ||
| DefaultMaxReorgDepth = 100 | ||
| DefaultMaxTableSize = 256 << 20 |
There was a problem hiding this comment.
Eventhough you left a comment below that explains what size this is, could you leave a note here too?
| if config.MemoryLimitDisabled { | ||
| performanceOpts := database.PerformanceBadgerOptions(dataPath) | ||
| // Use an extended table size for larger commits. | ||
| performanceOpts.MaxTableSize = config.MaxTableSize |
There was a problem hiding this comment.
I'd conditionally overwrite performanceOpts.MaxTableSize if config.MaxTableSize is not nil. (once you make the pointer change above)
|
@patrick-ogrady is this change relevant because you did change it upstream so it should work without this change now in coinbase/mesh-sdk-go#267 Those performance settings are good enough for it to work |
|
Closed in favour of upstream changes that made this irrelevant |
|
I think for now it makes sense to close this. In the future, it may be better to add a "super performance" option that uses even more aggressive settings (so users don't need to get into the weeds with table size or value log size). |
2 participants
Fixes syscoin/rosetta-syscoin#1
This fixes check:data being stuck on larger blocks with more changes and is synonymous with rosetta-syscoin settings here:
https://github.com/syscoin/rosetta-syscoin/blob/master/indexer/indexer.go#L130
Since the client can have those settings configurable it makes sense for CLI to have it configurable as well. We need this in order for check:data to work.